AppFuse

Extend appfuse maven plugin to allow sub-packages

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.1
  • Fix Version/s: 2.1.0
  • Component/s: Tools - AMP
  • Labels:
    None
  • Environment:
    all

Description

Using AMP with sub-packages is an essential thing. So I checked out AMP from svn repository and made a quick (and dirty ?) improvement to be aware of subpackages.
I didn't test it very much, just made the modification in AppFuseGeneratorMojo and tryied it in a "core" and "web" project and it worked.

It was a really small modification, I think it can be integrated easily (well the hard part is testing, isn't it ?).

The modified class is in attachment.

  1. Text File
    APF-1012.patch
    04/Feb/08 9:40 AM
    2 kB
    Edouard Laroche-Joubert
  2. Text File
    APF-1012.patch
    04/Feb/08 1:43 AM
    2 kB
    Edouard Laroche-Joubert
  3. Java Source File
    AppFuseGeneratorMojo.java
    01/Feb/08 6:34 AM
    14 kB
    Edouard Laroche-Joubert

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Raible added a comment -

Thanks for the patch! Is it possible to attach a diff instead of the whole file? Use "svn diff > APF-1012.patch" to create it.

Show
Matt Raible added a comment - Thanks for the patch! Is it possible to attach a diff instead of the whole file? Use "svn diff > APF-1012 .patch" to create it.
Matt Raible made changes -
Field Original Value New Value
Fix Version/s 2.0.2 [ 10110 ]
Affects Version/s 2.0.1 [ 10092 ]
Affects Version/s 2.0.2 [ 10110 ]
Hide
Permalink
Edouard Laroche-Joubert added a comment -

Yep sorry, actually I've found a bug in the "web" part module (because of the "if ... war ..." part I think). It's not a big thing, it generates two Action class (and jsp as well): one in the sub package, and an other one in the main package.
Maybe it indicates that it was generating the files twice.
I'll look at this, correct it and send the diff

happy to help.

Show
Edouard Laroche-Joubert added a comment - Yep sorry, actually I've found a bug in the "web" part module (because of the "if ... war ..." part I think). It's not a big thing, it generates two Action class (and jsp as well): one in the sub package, and an other one in the main package. Maybe it indicates that it was generating the files twice. I'll look at this, correct it and send the diff happy to help.
Hide
Permalink
Edouard Laroche-Joubert added a comment -

Still got the Action bug (two generations) but it's a start.

Show
Edouard Laroche-Joubert added a comment - Still got the Action bug (two generations) but it's a start.
Edouard Laroche-Joubert made changes -
Attachment APF-1012.patch [ 10458 ]
Hide
Permalink
Edouard Laroche-Joubert added a comment -

sorry the previous one was wrong.

Show
Edouard Laroche-Joubert added a comment - sorry the previous one was wrong.
Edouard Laroche-Joubert made changes -
Attachment APF-1012.patch [ 10459 ]
Hide
Permalink
Matt Raible added a comment -

I don't see how this patch helps anything. Do you have to set additional configuration properties in your pom.xml for this to work?

Show
Matt Raible added a comment - I don't see how this patch helps anything. Do you have to set additional configuration properties in your pom.xml for this to work?
Matt Raible made changes -
Fix Version/s 2.1 [ 10031 ]
Fix Version/s 2.0.2 [ 10110 ]
Hide
Permalink
Edouard Laroche-Joubert added a comment -

Hi Matt,

well when you want your code to be generated you use: mvn appfuse:gen -Dentity=Person

that works fine, it generates it in org.appfuse.model.Person, org.appfuse.dao.PersonDao etc.... But what about having a package in between for example : org.appfuse.salary.model.Person, org.appfuse.dao.PersonDao, etc..
You have to refactor all the classes, check the xml files etc...

here you use: mvn appfuse:gen -Dentity=Person -DfullPath=org.appfuse.salary.model
(or something like that, I forgot a bit about, I did it the 4th of february sorry).

and it generates : org.appfuse.salary.model.Person, org.appfuse.salary.dao.PersonDao, etc.

Show
Edouard Laroche-Joubert added a comment - Hi Matt, well when you want your code to be generated you use: mvn appfuse:gen -Dentity=Person that works fine, it generates it in org.appfuse.model.Person, org.appfuse.dao.PersonDao etc.... But what about having a package in between for example : org.appfuse.salary.model.Person, org.appfuse.dao.PersonDao, etc.. You have to refactor all the classes, check the xml files etc... here you use: mvn appfuse:gen -Dentity=Person -DfullPath=org.appfuse.salary.model (or something like that, I forgot a bit about, I did it the 4th of february sorry). and it generates : org.appfuse.salary.model.Person, org.appfuse.salary.dao.PersonDao, etc.
Matt Raible made changes -
Fix Version/s 2.1.0-M2 [ 10210 ]
Fix Version/s 2.1.0-M1 [ 10031 ]
Matt Raible made changes -
Fix Version/s 2.1.0 [ 10211 ]
Fix Version/s 2.1.0-M2 [ 10210 ]
Matt Raible made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Create a new review for changeset 65e2b45c4098de872fac7fd05499f0958bde6018
Matt Raible <matt@raibledesigns.com> submitted changeset 65e2b45c4098de872fac7fd05499f0958bde6018 to wicket in appfuse (7 files) - 28/Dec/10 7:29 PM

APF-1012: Added support for sub-packages when generating code.

Show
Create a new review for changeset 65e2b45c4098de872fac7fd05499f0958bde6018
Matt Raible <matt@raibledesigns.com> submitted changeset 65e2b45c4098de872fac7fd05499f0958bde6018 to wicket in appfuse (7 files) - 28/Dec/10 7:29 PM
Hide
Permalink
Matt Raible added a comment -

Fixed and documented at http://appfuse.org/display/APF/AppFuse+Maven+Plugin.

The default package name is $

{groupId}.model.Name. If you want to generate your code in a sub-package, specify a full package name like -Dentity=com.myproject.subpackage.model.Name or -Dentity=~.subpackage.model.Name. The tilde is a shortcut for ${groupId}

.

Show
Matt Raible added a comment - Fixed and documented at http://appfuse.org/display/APF/AppFuse+Maven+Plugin . The default package name is $ {groupId}.model.Name. If you want to generate your code in a sub-package, specify a full package name like -Dentity=com.myproject.subpackage.model.Name or -Dentity=~.subpackage.model.Name. The tilde is a shortcut for ${groupId} .
Matt Raible made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Matt Raible
    Reporter:
    Edouard Laroche-Joubert
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: