Issue Details (XML | Word | Printable)

Key: APF-1032
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Matt Raible
Reporter: Kent Butler
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
AppFuse

s:textfield renders bad HTML when using labelposition="left"

Created: 08/Mar/08 10:30 PM   Updated: 03/May/08 11:56 AM   Resolved: 03/May/08 11:56 AM
Component/s: Web - Struts
Affects Version/s: 2.0.1
Fix Version/s: 2.0.2

File Attachments: 1. File controlheader.ftl (2 kB)
2. File patch.diff (0.6 kB)

Environment: WinXP, Appfuse 2, Struts 2, css_xhtml


 Description  « Hide
When using Struts2 with css_xhtml - the struts textfield tag generates bad HTML when selecting labelposition="left". This is due to template/css_xhtml/controlheader.ftl, around line 11 which declares an open div tag for label position 'top' but no span tag for left positioning.

This is the code missing the else

    <#if parameters.labelposition?default("top") == 'top'>
    <div <#rt/>
    </#if>


Kent Butler added a comment - 08/Mar/08 11:05 PM
Added else block, line 11, to handle inline for left positioning of label.

Kent Butler made changes - 08/Mar/08 11:05 PM
Field Original Value New Value
Attachment controlheader.ftl [ 10473 ]
Kent Butler added a comment - 08/Mar/08 11:10 PM
Patch file rooted at appfuse/web/struts/src

Kent Butler made changes - 08/Mar/08 11:10 PM
Attachment patch.diff [ 10474 ]
Matt Raible made changes - 11/Mar/08 01:54 AM
Fix Version/s 2.0.2 [ 10110 ]
3116 by  Matt Raible (1 file)
03/May/08 11:55 AM (27 months, 15 days ago)
APF-1032: Fixed s:textfield renders bad HTML when using labelposition="left". Thanks Kent!
appfuse: trunk/web/struts/src/main/webapp/template/css_xhtml/controlheader.ftl 3116 history download (+2 -0) diffs

Matt Raible made changes - 03/May/08 11:56 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]