[#APF-1032] s:textfield renders bad HTML when using labelposition="left"

AppFuse

s:textfield renders bad HTML when using labelposition="left"

Created: 08/Mar/08 10:30 PM Updated: 03/May/08 11:56 AM

Component/s:

Web - Struts

Affects Version/s:

2.0.1

Fix Version/s:

2.0.2

File Attachments:	1. controlheader.ftl (2 kb) 2. patch.diff (0.6 kb)
Environment:	WinXP, Appfuse 2, Struts 2, css_xhtml

Description

« Hide

When using Struts2 with css_xhtml - the struts textfield tag generates bad HTML when selecting labelposition="left". This is due to template/css_xhtml/controlheader.ftl, around line 11 which declares an open div tag for label position 'top' but no span tag for left positioning.

This is the code missing the else

    <#if parameters.labelposition?default("top") == 'top'>
    <div <#rt/>
    </#if>

All

Comments

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Kent Butler - 08/Mar/08 11:05 PM

Added else block, line 11, to handle inline for left positioning of label.

[ Permlink | « Hide ]

Kent Butler - 08/Mar/08 11:10 PM

Patch file rooted at appfuse/web/struts/src