AppFuse

I18n for displaytag

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8, 1.8.1, 1.8.2
  • Fix Version/s: 1.9.1
  • Component/s: i18n
  • Labels:
    None

Description

Need add i18n resources for displaytag, like displaytag_zh_CN.properties, under \WEB-INF\classes.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Raible added a comment -

If you provide the file that I should add, I'll add it.

Show
Matt Raible added a comment - If you provide the file that I should add, I'll add it.
Hide
Permalink
Matt Raible added a comment -

Changed version it applies to. I'm more than happy to add these files, but need translations to do so (and to show it's important to users .

Show
Matt Raible added a comment - Changed version it applies to. I'm more than happy to add these files, but need translations to do so (and to show it's important to users .
Hide
Permalink
Paul Wang added a comment -

Hi Matt,

Please check the attached zip file. Take the following notes when you plan to apply this patches,
1. Unzip the attached file, put displaytag_zh_CN.properties under /web/WEB-INF/classes,
2. Modify build.xml to allow convert displaytag_zh_CN.properties using native2ascii,
3. In compliance with i18n of displaytag, I modified userList.jsp like the following,
<display:setProperty name="paging.banner.item_name"><fmt:message key="display.user"/></display:setProperty>
<display:setProperty name="paging.banner.items_name"><fmt:message key="display.users"/></display:setProperty>
4. For the compliance, also made some addition to ApplicationResources.properties, ApplicationResources_zh.properties, ApplicationResources_zh_CN.properties. Made some changes to other .properties files if applicable.

Based on the curerent CVS version, I made the above-mentioned changes and finished the testing on my desktop. I also attached the affected files, please apply these changes when possible. I suppose it could be better if other .properties files are ready, because I don't know these languages. Anyway, you can step 1 and 2 w/o any risks.

Appfuse is a great project, appreciate all the jobs you'v been done.

Regards,
Paul

Show
Paul Wang added a comment - Hi Matt, Please check the attached zip file. Take the following notes when you plan to apply this patches, 1. Unzip the attached file, put displaytag_zh_CN.properties under /web/WEB-INF/classes, 2. Modify build.xml to allow convert displaytag_zh_CN.properties using native2ascii, 3. In compliance with i18n of displaytag, I modified userList.jsp like the following, <display:setProperty name="paging.banner.item_name"><fmt:message key="display.user"/></display:setProperty> <display:setProperty name="paging.banner.items_name"><fmt:message key="display.users"/></display:setProperty> 4. For the compliance, also made some addition to ApplicationResources.properties, ApplicationResources_zh.properties, ApplicationResources_zh_CN.properties. Made some changes to other .properties files if applicable. Based on the curerent CVS version, I made the above-mentioned changes and finished the testing on my desktop. I also attached the affected files, please apply these changes when possible. I suppose it could be better if other .properties files are ready, because I don't know these languages. Anyway, you can step 1 and 2 w/o any risks. Appfuse is a great project, appreciate all the jobs you'v been done. Regards, Paul
Hide
Permalink
Matt Raible added a comment -

Fix in 1.9.1 since there hasn't been a whole lot of demand for this.

Show
Matt Raible added a comment - Fix in 1.9.1 since there hasn't been a whole lot of demand for this.
Hide
Permalink
Matt Raible added a comment -

Added displaytag_zh_CN.properties to CVS. As far as using i18n keys for the object names, it might work best if we simply translate "item" and "items" and then add them to each resource bundle. If you'd like to see this, please open a new issue.

Show
Matt Raible added a comment - Added displaytag_zh_CN.properties to CVS. As far as using i18n keys for the object names, it might work best if we simply translate "item" and "items" and then add them to each resource bundle. If you'd like to see this, please open a new issue.

People

  • Assignee:
    Matt Raible
    Reporter:
    Paul Wang
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: