LocaleFilter call getParameter() may cause problem.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: None
  • Component/s: i18n
  • Labels:
    None

Description

In LocaleFilter, it call request.getParameter(), this may cause problem when some serlvet class need request.getInputStream():
As spec says:
"If the parameter data was sent in the request body, such as occurs with
an HTTP POST request, then reading the body directly via .getInputStream or
.getReader can interfere with the execution of .getParameter method."

Further, getParameter won't work when request is encryt type. Is there any good way to make LocaleFilter more general?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Raible added a comment -
I haven't heard any reports from users claiming that they've experienced these problems. Have you experienced any of them. I'm inclined to close this issue as it's merely a suggestion of a bug that *could* happen rather than a bug that *does* happen. ;-)
Show
Matt Raible added a comment - I haven't heard any reports from users claiming that they've experienced these problems. Have you experienced any of them. I'm inclined to close this issue as it's merely a suggestion of a bug that *could* happen rather than a bug that *does* happen. ;-)
Hide
Permalink
Matt Raible added a comment -
Closing since this is a problem then *could* happen, not a problem that *does* happen. ;-)
Show
Matt Raible added a comment - Closing since this is a problem then *could* happen, not a problem that *does* happen. ;-)

People

  • Assignee:
    Matt Raible
    Reporter:
    dapeng.ni
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: