AppFuse JIRA

  • Log In Access more options
    • Online Help
    • GreenHopper Help
    • Agile Answers
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Agile
  • AppFuse
  • APF-655

MailEngine.sendMessage method used for sending attachments does not preserve application-wide 'sender' property.

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-M2, 2.0-M3
  • Fix Version/s: 2.0-M4
  • Component/s: Service Layer
  • Labels:
    None

Description

There's no facility in the MailEngine.sendMessage method (javadoc that says: Convenience method for sending messages with attachments.) for maintaining that the sender/from attribute is consistent with what is specified in mail.properties.

I propose that the method signature has 'String sender' added to it. This makes sense to me, because the caller of this method most likely has access to the 'mailMessage' bean from the Spring app context, which can be used to get the from address.
  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    MailEngine.patch
    20/Feb/07 6:38 PM
    1 kB
    Bryan Noll

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
  • Source
Hide
Permalink
Bryan Noll added a comment - 20/Feb/07 6:38 PM
The code as it is (before this patch) does the following. If using the method in this class that sends mail with an attachment, the 'from' address is...

bnoll@baitshop

...where bnoll is my username and baitshop is my hostname.

Obviously not a real email address, just something it grocked from the environment. This patch makes that 'from' address be whatever was set in the mail.properties file.
Show
Bryan Noll added a comment - 20/Feb/07 6:38 PM The code as it is (before this patch) does the following. If using the method in this class that sends mail with an attachment, the 'from' address is... bnoll@baitshop ...where bnoll is my username and baitshop is my hostname. Obviously not a real email address, just something it grocked from the environment. This patch makes that 'from' address be whatever was set in the mail.properties file.
Hide
Permalink
Bryan Noll added a comment - 21/Feb/07 9:39 AM
Checked in fix and tests to support. See MailEngineTest.java in the services module.
Show
Bryan Noll added a comment - 21/Feb/07 9:39 AM Checked in fix and tests to support. See MailEngineTest.java in the services module.
Hide
Permalink
Bryan Noll added a comment - 21/Feb/07 9:39 AM
closing
Show
Bryan Noll added a comment - 21/Feb/07 9:39 AM closing

People

  • Assignee:
    Bryan Noll
    Reporter:
    Bryan Noll
Vote (0)
Watch (0)

Dates

  • Created:
    20/Feb/07 4:50 PM
    Updated:
    21/Feb/07 9:39 AM
    Resolved:
    21/Feb/07 9:39 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for AppFuse. Try JIRA - bug tracking software for your team.