[#APF-682] BaseControllerTestCase hard-coded username "tomcat" - AppFuse JIRA

AppFuse

BaseControllerTestCase hard-coded username "tomcat"

Created: 07/Mar/07 11:42 AM Updated: 07/Mar/07 02:12 PM Resolved: 07/Mar/07 02:09 PM

Component/s:

Build, Test, or Deploy Process

Affects Version/s:

2.0-M4

Fix Version/s:

2.0-M4

Description

« Hide

org.appfuse.webapp.controller.BaseControllerTestCase has username "tomcat" hard-coded, so when user modified the default username in sample-data.xml, this issue might cause test failed.

Sort Order:

Matt Raible made changes - 07/Mar/07 11:54 AM

Field	Original Value	New Value
Fix Version/s		2.0-M4 [ 10130 ]

[ Permalink | « Hide ]

Matt Raible added a comment - 07/Mar/07 01:16 PM

Do you see any issues with removing the population of the protected "user" object altogether? This is left over from pre-Acegi days and pre "good security" as well - where we looked in the session for the user rather than using request.getRemoteUser().

2560 by Matt Raible (6 files)

07/Mar/07 02:01 PM (41 months, 4 days ago)

~~APF-682~~: Removed User object from Base*TestCase classes

appfuse: trunk/web/tapestry/src/test/java/org/appfuse/webapp/pages/UserFormTest.java 2560

(+2 -0) diffs

appfuse: trunk/web/spring/src/test/java/org/appfuse/webapp/controller/UserFormControllerTest.java 2560

(+2 -0) diffs

appfuse: trunk/web/tapestry/src/main/java/org/appfuse/webapp/pages/BasePageTestCase.java 2560

(+1 -13) diffs

appfuse: trunk/web/jsf/src/main/java/org/appfuse/webapp/action/BasePageTestCase.java 2560

(+2 -8) diffs

appfuse: trunk/web/jsf/src/test/java/org/appfuse/webapp/action/UserFormTest.java 2560

(+5 -1) diffs

appfuse: trunk/web/spring/src/main/java/org/appfuse/webapp/controller/BaseControllerTestCase.java 2560

(+0 -12) diffs

Matt Raible made changes - 07/Mar/07 02:09 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Matt Raible added a comment - 07/Mar/07 02:12 PM

I removed "user" in the Base*TestCase classes. Note that the following still exists in Tapestry's BasePageTestCase:

MockHttpServletRequest request = new MockHttpServletRequest();
request.setRemoteUser("tomcat");

We should probably change "tomcat/tomcat" to "user/user" and "mraible/tomcat" to be "admin/admin" - I think that would be more acceptable by users.