[#APF-750] one jmock question: no need for dao.verify - AppFuse JIRA

AppFuse

one jmock question: no need for dao.verify

Created: 17/May/07 01:45 AM Updated: 30/Aug/07 01:57 AM Resolved: 30/Aug/07 01:57 AM

Component/s:

Build, Test, or Deploy Process

Affects Version/s:

2.0-M4

Fix Version/s:

2.0-RC1

File Attachments:

patch.txt (11 kB)

Description

« Hide

In every method of PersonManagerImplTest, there is a line

dao.verify();

but it seems that the line is not necessary, super class
MockObjectTestCase will do the verify job automatically !

so, just remove the line !!

Sort Order:

Matt Raible made changes - 17/May/07 01:50 AM

Field	Original Value	New Value
Fix Version/s		2.0-M5 [ 10141 ]

Matt Raible made changes - 17/May/07 01:51 AM

Fix Version/s		2.0 Final [ 10113 ]
Fix Version/s	2.0-M5 [ 10141 ]

Matt Raible made changes - 23/May/07 08:57 PM

Fix Version/s		2.0-RC1 [ 10151 ]
Fix Version/s	2.0 Final [ 10113 ]

[ Permalink | « Hide ]

Matt Raible added a comment - 01/Jun/07 10:23 PM

Hopefully we can solve ~~APF-661~~ before this one. That way, we only need to update the code in SVN and it'll be updated in the tutorial.

[ Permalink | « Hide ]

Trent Bartlem added a comment - 09/Jul/07 04:52 AM

No promises, but hope this helps.

Trent Bartlem made changes - 09/Jul/07 04:52 AM

Attachment

patch.txt [ 10356 ]

Trent Bartlem made changes - 12/Jul/07 07:27 PM

Comment	No promises, but hope this helps. [ 11915 ]	No promises, but hope this helps. [ 11915 ]
Security	jira-users

2832 by Matt Raible (4 files)

13/Aug/07 11:43 PM (35 months, 30 days ago)

~~APF-750~~: Removed .verify() calls in jMock tests that extend MockObjectTestCase.

appfuse: trunk/service/src/test/java/org/appfuse/service/impl/UserManagerImplTest.java 2832

(+1 -16) diffs

appfuse: trunk/service/src/test/java/org/appfuse/service/impl/LookupManagerImplTest.java 2832

(+2 -3) diffs

appfuse: trunk/service/src/test/java/org/appfuse/service/impl/UniversalManagerTest.java 2832

(+28 -32) diffs

appfuse: trunk/service/src/test/java/org/appfuse/service/UserSecurityAdviceTest.java 2832

(+0 -4) diffs

[ Permalink | « Hide ]

Matt Raible added a comment - 13/Aug/07 11:44 PM

Thanks for the patch Trent - I've applied it in SVN.

http://fisheye4.cenqua.com/changelog/appfuse?cs=2832

This issue remains open as all the tutorials still need to have this change made to them.

Matt Raible made changes - 13/Aug/07 11:44 PM

Status

Open [ 1 ]

In Progress [ 3 ]

[ Permalink | « Hide ]

Matt Raible added a comment - 30/Aug/07 01:57 AM

Resolved manually for demos since Snippet plugin seems to have issues (~~APF-661~~).

Matt Raible made changes - 30/Aug/07 01:57 AM

Status	In Progress [ 3 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]