Issue Details (XML | Word | Printable)

Key: APF-861
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Matt Raible
Reporter: Matt Raible
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
AppFuse

Fix Checkstyle issues: javadoc, line length, etc.

Created: 29/Aug/07 11:54 PM   Updated: 30/Aug/07 12:15 AM   Resolved: 30/Aug/07 12:15 AM
Component/s: Persistence Layer, Service Layer, Web - Struts
Affects Version/s: 2.0-M5
Fix Version/s: 2.0-RC1

File Attachments: 1. Text File checkstyle.patch (158 kB)



 Description  « Hide
While working at Checkmate Technologies (http://checkmate-tech.blogspot.com) earlier this year, I did a lot of work to fix Checkstyle issues in the data, hibernate, service and web (Struts 2) layers of AppFuse. They've agreed to donate this work - this bug is to track that donation.

It's likely we'll want to continue to improve Javadocs and fix Checkstyle issues, but I'd like to track this donation as a single issue for 2.0.

Matt Raible added a comment - 30/Aug/07 12:02 AM
Contribution includes the attached patch as well as the beginnings of the checkstyle.xml located at https://appfuse.dev.java.net/checkstyle.xml.

Matt Raible made changes - 30/Aug/07 12:02 AM
Field Original Value New Value
Attachment checkstyle.patch [ 10392 ]
2872 by  Matt Raible (79 files)
30/Aug/07 12:05 AM (35 months, 14 days ago)
APF-861: While working at Checkmate Technologies (http://checkmate-tech.blogspot.com) earlier this year, I did a lot of work to fix Checkstyle issues in the data, hibernate, service and web (Struts 2) layers of AppFuse. They've agreed to donate this code - thanks guys!
appfuse: trunk/web/struts/src/main/java/org/appfuse/webapp/action/FileUploadAction.java 2872 history download (+24 -8) diffs
appfuse: trunk/data/hibernate/src/main/java/org/appfuse/dao/hibernate/GenericDaoHibernate.java 2872 history download (+30 -10) diffs
appfuse: trunk/data/jpa-hibernate/src/main/java/org/appfuse/dao/jpa/UniversalDaoJpa.java 2872 history download (+16 -11) diffs
appfuse: trunk/data/jpa-hibernate/src/main/java/org/appfuse/dao/jpa/GenericDaoJpa.java 2872 history download (+39 -18) diffs
appfuse: trunk/data/jpa-hibernate/src/main/java/org/appfuse/dao/BaseDaoTestCase.java 2872 history download (+16 -3) diffs
appfuse: trunk/service/src/main/java/org/appfuse/util/DateConverter.java 2872 history download (+25 -8) diffs
appfuse: trunk/data/ibatis/src/main/java/org/appfuse/dao/UniversalDao.java 2872 history download (+6 -5) diffs
appfuse: trunk/data/jpa-hibernate/src/main/java/org/appfuse/dao/GenericDao.java 2872 history download (+10 -7) diffs
appfuse: trunk/service/src/main/java/org/appfuse/service/UserExistsException.java 2872 history download (+1 -1) diffs
appfuse: trunk/data/hibernate/src/main/java/org/appfuse/dao/spring/HibernateExtensionPostProcessor.java 2872 history download (+20 -18) diffs
appfuse: trunk/service/src/main/java/org/appfuse/service/impl/RoleManagerImpl.java 2872 history download (+12 -0) diffs
appfuse: trunk/web/struts/src/main/java/org/appfuse/webapp/action/PasswordHintAction.java 2872 history download (+21 -12) diffs
appfuse: trunk/data/hibernate/src/main/java/org/appfuse/dao/hibernate/RoleDaoHibernate.java 2872 history download (+10 -1) diffs
appfuse: trunk/data/jpa-hibernate/src/main/java/org/appfuse/dao/jpa/LookupDaoJpa.java 2872 history download (+1 -1) diffs
appfuse: trunk/service/src/main/java/org/appfuse/util/StringUtil.java 2872 history download (+11 -8) diffs
appfuse: trunk/data/ibatis/src/main/java/org/appfuse/dao/RoleDao.java 2872 history download (+4 -4) diffs
appfuse: trunk/data/common/src/main/java/org/appfuse/Constants.java 2872 history download (+22 -13) diffs
appfuse: trunk/service/src/main/java/org/appfuse/service/impl/GenericManagerImpl.java 2872 history download (+30 -2) diffs
appfuse: trunk/service/src/main/java/org/appfuse/service/LookupManager.java 2872 history download (+1 -1) diffs
appfuse: trunk/web/struts/src/main/java/org/appfuse/webapp/action/BaseAction.java 2872 history download (+82 -28) diffs
appfuse: trunk/data/hibernate/src/main/java/org/appfuse/dao/hibernate/LookupDaoHibernate.java 2872 history download (+1 -1) diffs
appfuse: trunk/service/src/main/java/org/appfuse/service/UserService.java 2872 history download (+5 -5) diffs
appfuse: trunk/data/jpa-hibernate/src/main/java/org/appfuse/dao/RoleDao.java 2872 history download (+4 -4) diffs
appfuse: trunk/service/src/main/java/org/appfuse/service/UniversalManager.java 2872 history download (+26 -5) diffs
appfuse: trunk/data/hibernate/src/main/java/org/appfuse/dao/LookupDao.java 2872 history download (+2 -2) diffs
appfuse: trunk/data/common/src/main/java/org/appfuse/model/BaseObject.java 2872 history download (+21 -2) diffs
appfuse: trunk/web/common/src/main/java/org/appfuse/webapp/filter/LocaleFilter.java 2872 history download (+10 -0) diffs
appfuse: trunk/web/common/src/main/java/org/appfuse/webapp/taglib/ConstantsTei.java 2872 history download (+10 -8) diffs
appfuse: trunk/data/ibatis/src/main/java/org/appfuse/dao/BaseDaoTestCase.java 2872 history download (+21 -8) diffs
appfuse: trunk/data/ibatis/src/main/java/org/appfuse/dao/ibatis/UserDaoiBatis.java 2872 history download (+19 -13) diffs
...49 more files in changeset

Matt Raible made changes - 30/Aug/07 12:15 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]