Issue Details (XML | Word | Printable)

Key: APF-874
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Won't Fix
Priority: Major Major
Assignee: Matt Raible
Reporter: Matt Raible
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
AppFuse

Change groupId of appfuse-maven-plugin to org.appfuse

Created: 05/Sep/07 11:15 PM   Updated: 06/Sep/07 06:07 PM   Resolved: 06/Sep/07 06:07 PM
Component/s: Tools - AMP
Affects Version/s: 2.0-RC1
Fix Version/s: 2.0 Final

File Attachments: None
Image Attachments:

1. irc-log.png
(256 kB)

2. irc-log2.png
(247 kB)


 Description  « Hide
In order to get the appfuse-maven-plugin uploaded to Maven's Central repository, it can't have org.codehaus.mojo as its groupId. The original reason I started using this groupId is because I couldn't get the "appfuse" prefix to work w/o it. Now the prefix seems to work fine (at least locally).

http://jira.codehaus.org/browse/MAVENUPLOAD-1701

NOTE: We realize it makes good sense to change the groupIds to be more specific than "org.appfuse" for many of AppFuse's modules. However, it seems somewhat risky to do this late in the 2.0 game. If we do decide to change them, we'll likely do it for 2.1. Please comment on the following thread if you have any opinions on this:

http://www.nabble.com/Thinking-out-loud-about-groupIds-tf4387544s2369.html


2926 by  Matt Raible (14 files)
05/Sep/07 11:16 PM (35 months, 7 days ago)
APF-874: Changed the appfuse-maven-plugin's groupId to org.appfuse.

In order to get the appfuse-maven-plugin uploaded to Maven's Central repository, it can't have org.codehaus.mojo as its groupId. The original reason I started using this groupId is because I couldn't get the "appfuse" prefix to work w/o it. Now the prefix seems to work fine (at least locally).

http://jira.codehaus.org/browse/MAVENUPLOAD-1701

NOTE: We realize it makes good sense to change the groupIds to be more specific than "org.appfuse" for many of AppFuse's modules. However, it seems somewhat risky to do this late in the 2.0 game. If we do decide to change them, we'll likely do it for 2.1. Please comment on the following thread if you have any opinions on this:

http://www.nabble.com/Thinking-out-loud-about-groupIds-tf4387544s2369.html
appfuse: trunk/archetypes/appfuse-core/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -18) diffs
appfuse: trunk/archetypes/appfuse-modular-spring/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -18) diffs
appfuse: trunk/archetypes/appfuse-basic-struts/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -36) diffs
appfuse: trunk/archetypes/appfuse-modular-jsf/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -18) diffs
appfuse: trunk/archetypes/appfuse-basic-jsf/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -36) diffs
appfuse: trunk/archetypes/appfuse-basic-spring/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -36) diffs
appfuse: trunk/web/common/pom.xml 2926 history download (+1 -1) diffs
appfuse: trunk/archetypes/appfuse-modular-struts/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -18) diffs
appfuse: trunk/web/struts/pom.xml 2926 history download (+1 -1) diffs
appfuse: trunk/plugins/maven-warpath-plugin/pom.xml 2926 history download (+2 -9) diffs
appfuse: trunk/archetypes/appfuse-basic-tapestry/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -36) diffs
appfuse: trunk/archetypes/appfuse-modular-tapestry/src/main/resources/archetype-resources/pom.xml 2926 history download (+18 -18) diffs
appfuse: trunk/plugins/appfuse-maven-plugin/src/main/java/org/appfuse/mojo/HibernateExporterMojo.java 2926 history download (+1 -1) diffs
appfuse: trunk/plugins/appfuse-maven-plugin/pom.xml 2926 history download (+13 -71) diffs

Matt Raible made changes - 05/Sep/07 11:16 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
2928 by  Matt Raible (2 files)
05/Sep/07 11:21 PM (35 months, 7 days ago)
2930 by  Matt Raible (2 files)
06/Sep/07 12:36 PM (35 months, 7 days ago)
Matt Raible added a comment - 06/Sep/07 03:33 PM
If we want to allow users to type "appfuse:*", they'll need to register the plugin in their ~/.m2/settings.xml with this change. Therefore, I'm reverting to org.codehaus.mojo as its easier for users. We won't be able to upload AMP to Maven's central repo until we move to Codehaus, but that's OK IMO.




Matt Raible made changes - 06/Sep/07 03:33 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Matt Raible added a comment - 06/Sep/07 03:34 PM
Screenshot of IRC Conversation confirming that org.codehaus.mojo or org.apache.maven.plugins must be used to get "appfuse:*" prefix.

Matt Raible made changes - 06/Sep/07 03:34 PM
Attachment irc-log.png [ 10393 ]
Matt Raible added a comment - 06/Sep/07 04:11 PM
After more IRC discussions, it appears it *is* possible, but the fact that we're already using org.codehaus.mojo causes that one to always be picked up first. See attached irc-log2.png for more information.

Since we're approaching 2.0, I'm going to leave it as org.codehaus.org for now. We can rename it to something else when Maven allows the search order to be configurable or we're ready to remove it completely from AppFuse's repository. Another option is to get everything in Maven's central repository and disable AppFuse's repository so the new one is found instead.

Matt Raible made changes - 06/Sep/07 04:11 PM
Attachment irc-log2.png [ 10394 ]
Matt Raible made changes - 06/Sep/07 06:07 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Won't Fix [ 2 ]
2933 by  Matt Raible (11 files)
06/Sep/07 08:01 PM (35 months, 6 days ago)
APF-874: Changed groupId from org.appfuse back to org.codehaus.mojo.

If we want to allow users to type "appfuse:*", they'll need to register the plugin in their ~/.m2/settings.xml with this change. Therefore, I'm reverting to org.codehaus.mojo as its easier for users. We won't be able to upload AMP to Maven's central repo until we move to Codehaus, but that's OK IMO.

After more IRC discussions, it appears it *is* possible to distribute this plugin w/o requiring users to modify settings.xml, but the fact that we're already using org.codehaus.mojo causes that one to always be picked up first.

Since we're approaching 2.0, I'm going to leave it as org.codehaus.org for now. We can rename it to something else when Maven allows the search order to be configurable or we're ready to remove it completely from AppFuse's repository. Another option is to get everything in Maven's central repository and disable AppFuse's repository so the new one is found instead.
appfuse: trunk/archetypes/appfuse-core/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/archetypes/appfuse-modular-spring/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/archetypes/appfuse-basic-struts/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/archetypes/appfuse-modular-jsf/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/archetypes/appfuse-basic-tapestry/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/archetypes/appfuse-basic-jsf/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/web/tapestry/pom.xml 2933 history download (+5 -0) diffs
appfuse: trunk/archetypes/appfuse-modular-tapestry/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/archetypes/appfuse-basic-spring/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs
appfuse: trunk/pom.xml 2933 history download (+1 -0) diffs
appfuse: trunk/archetypes/appfuse-modular-struts/src/main/resources/archetype-resources/pom.xml 2933 history download (+1 -1) diffs